-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support node VOLUME_MOUNT_GROUP cap in test #349
Conversation
/lgtm |
/assign @msau42 |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Does this change affect testing CSI drivers in any way? |
Could it be that this change is necessary when testing CSI drivers that advertise the new If yes, then this should be mentioned in the change note. |
@pohly yep you are exactly right. Without this change, I would assume the drivers that advertise this capability will fail the sanity test. It does have a release-note doesn't it? |
shall we have a new release for this change? |
Yes, but it wasn't obvious what "support node VOLUME_MOUNT_GROUP cap in test" means (who needs this support, under which circumstances?). Can we change it into "avoid test failures when a CSI driver advertises the VOLUME_MOUNT_GROUP capability from CSI 1.5"?
That is what we were discussing yesterday in the CSI meeting. Because the purpose of this PR wasn't clear, we didn't come to a conclusion. But now it seems that we should do a new release because of this issue. |
@pohly done, release note changed. |
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
support node VOLUME_MOUNT_GROUP cap, this is a new node capability added in CSI v1.5.0 spec
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: