Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support node VOLUME_MOUNT_GROUP cap in test #349

Merged
merged 1 commit into from
Aug 19, 2021
Merged

support node VOLUME_MOUNT_GROUP cap in test #349

merged 1 commit into from
Aug 19, 2021

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Aug 19, 2021 •
edited
Loading

What type of PR is this?
/kind failing-test

What this PR does / why we need it:
support node VOLUME_MOUNT_GROUP cap, this is a new node capability added in CSI v1.5.0 spec

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

avoid test failures when a CSI driver advertises the VOLUME_MOUNT_GROUP capability from CSI 1.5

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 19, 2021
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 19, 2021
@gnufied
Copy link
Contributor

gnufied commented Aug 19, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 19, 2021
@andyzhangx
Copy link
Member Author

/assign @msau42

@xing-yang
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2021
@k8s-ci-robot k8s-ci-robot merged commit fbf2080 into kubernetes-csi:master Aug 19, 2021
@pohly
Copy link
Contributor

pohly commented Oct 6, 2021

Does this change affect testing CSI drivers in any way?

@pohly
Copy link
Contributor

pohly commented Oct 6, 2021

Could it be that this change is necessary when testing CSI drivers that advertise the new VOLUME_MOUNT_GROUP capability because otherwise the default case will cause a test failure?

If yes, then this should be mentioned in the change note.

@gnufied
Copy link
Contributor

gnufied commented Oct 6, 2021

@pohly yep you are exactly right. Without this change, I would assume the drivers that advertise this capability will fail the sanity test. It does have a release-note doesn't it?

@andyzhangx
Copy link
Member Author

shall we have a new release for this change?

@pohly
Copy link
Contributor

pohly commented Oct 7, 2021

It does have a release-note doesn't it?

Yes, but it wasn't obvious what "support node VOLUME_MOUNT_GROUP cap in test" means (who needs this support, under which circumstances?).

Can we change it into "avoid test failures when a CSI driver advertises the VOLUME_MOUNT_GROUP capability from CSI 1.5"?

shall we have a new release for this change?

That is what we were discussing yesterday in the CSI meeting. Because the purpose of this PR wasn't clear, we didn't come to a conclusion. But now it seems that we should do a new release because of this issue.

@andyzhangx
Copy link
Member Author

It does have a release-note doesn't it?

Yes, but it wasn't obvious what "support node VOLUME_MOUNT_GROUP cap in test" means (who needs this support, under which circumstances?).

Can we change it into "avoid test failures when a CSI driver advertises the VOLUME_MOUNT_GROUP capability from CSI 1.5"?

shall we have a new release for this change?

That is what we were discussing yesterday in the CSI meeting. Because the purpose of this PR wasn't clear, we didn't come to a conclusion. But now it seems that we should do a new release because of this issue.

@pohly done, release note changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnufied gnufied Awaiting requested review from gnufied

@xing-yang xing-yang Awaiting requested review from xing-yang

Assignees

@gnufied gnufied

@xing-yang xing-yang

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@andyzhangx @gnufied @xing-yang @k8s-ci-robot @pohly @msau42